fix(session): Safari bug with delayed set of cookies #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AdamGhst As Safari requires builds, I'll test it. However, I would like you to test other platforms to be sure that login/logout and sync (it uses cookies) works as before. |
|
Builds for commit d9a6ddd: |
smalluban
force-pushed
the
fix-safari-session
branch
from
d9a6ddd to
de4a762
Compare
|
Builds for commit de4a762: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug on iOS Safari 18.x, which makes the account section on settings page out of date after sucessful login.
Reproduce path (on production):
This PR also changes a patch for another bug to be feature-based, rather than fixed to the platform (in the case Safari would fix the bug). For example, the problem with starting point from wrong date for cookies is fixed in 18.x (src/utils/api.js#L60)
IMPORTANT NOTICE: There is still significant delay between old state and current one (we pull cookies up to 10 seconds to try it if they are there). Currently, there is no "better" way to that.